First, I want to let you know that my testing is ongoing and I have other minor bugs and nitpicks that will be in my full report. I have been reporting severe bugs directly to MK.
The first was the double barrelled musket bug, where Humphrey Douglas’s musket would just disappear upon completion of the quest. This was a simple fix, though, thanks to an old buho fix for it.
I’m going to explain the fix for anyone that currently has the problem. Note that this will not work on a savegame after you’ve already given him the musket and it has disappeared. Make sure to save before you give him the musket.
The file that needs to be changed is ForAll_dialog.c which is located in Program\DIALOGS\russian\Quest. In the file (which can be opened by a free program like Notepad++), search for DoubleMushket. You will find this:
AddQuestRecord(“SeekDoubleMushket”, “3”);
CloseQuestHeader(“SeekDoubleMushket”);
AddMoneyToCharacter(pchar, -sti(Npchar.quest.OfficerPrice.add));
npchar.model = “MusketeerEnglish_2”;
npchar.model.animation = “mushketer”;
npchar.MusketerDistance = 5;
npchar.greeting = “Gr_questOfficer”;
npchar.Dialog.Filename = “Enc_Officer_dialog.c”;
Pchar.questTemp.HiringOfficerIDX = GetCharacterIndex(Npchar.id);
npchar.OfficerWantToGo.DontGo = true; //не пытаться уйти
npchar.loyality = MAX_LOYALITY;
AddDialogExitQuestFunction(“LandEnc_OfficerHired”);
NextDiag.CurrentNode = NextDiag.TempNode;
NPChar.quest.meeting = true;
DialogExit();
Between npchar.loyality = MAX_LOYALITY; and AddDialogExitQuestFunction(“LandEnc_OfficerHired”); add this line:
LAi_type_warrior_Init(npchar);
Now when you give him the musket he will have it and his bullets and fire it in combat just fine. Thanks for buho for this old fix.
—–
Now, onto the second quest breaking bug that I have not been able to completely fix. This is a major issue in the Kill the Beggars questline. It has to do with the key found in the Keymaster’s house after paying him to make it, and the letter found on Oliver Trust’s desk near the end of the questline. These will appear just time the first time you go to get them, but if you reload a savegame before getting these items (even outside of the house they are in), they will not be there. This means if you die in the fights, you are basically stuck and the quest is broken.
For anyone with this problem, the only way to continue the quest without editing files is to reload a savegame that takes place before the last step of the quest. So you need to save before you talk to the keymaster and pay him to make that key and save before talking to the diplomat in a pirate town to get Oliver Trust’s location. Reloading those saves will ensure the items will appear. Just make sure you don’t die in the fights and save after you get the items. Make sure for all of these saves to save in different slots.
Now, onto why I’m not being able to fix this in the code. Making it so the key always appears is easy, but making it so the letter always appears messes with the descriptions (the way I’m trying to fix it at least). If you look in inititems.c in Program/ITEMS , you will find:
makeref(itm,Items[n]); //ключ для линейки ГПК
itm.id = “keyQuestLSC”;
itm.name = “itmname_keyQuestLSC”;
itm.describe = “itmdescr_keyQuestLSC”;
itm.model = “keymiddle”;
itm.picIndex = 15;
itm.picTexture = “ITEMS_12”;
itm.shown = 0; //сначала ключ невидим
itm.startLocation = “Villemstad_houseSp5”;
itm.startLocator = “item2”;
itm.Weight = 0.0;
itm.price = 0;
itm.ItemType = “QUESTITEMS”;
n++;
makeref(itm,Items[n]); //письмо для линейки ГПК
itm.id = “letter_LSC”;
itm.name = “itmname_letter_LSC”;
itm.describe = “itmdescr_letter_LSC”;
itm.model = “letter”;
itm.picIndex = 16;
itm.picTexture = “ITEMS_4”;
itm.price = 0;
itm.Weight = 0.1;
itm.ItemType = “QUESTITEMS”;
n++;
For keyQuestLSC, changing it to itm.shown = 1; is enough to get the key to appear, no problem.
It’s not a simple fix for letter_LSC, however, as that item is tied to three items with different descriptions (one letter in the Dutch governer-general’s chest you need the key for, one letter of Oliver Trust’s desk, and one letter in the Fernando Diffindur chest in the City of Abandoned Ships).
Adding the line itm.shown = 1; isn’t enough to fix it as it needs a location and locator, but even adding those doesn’t truly fix the problem.
makeref(itm,Items[n]);
itm.id = “letter_LSC”;
itm.name = “itmname_letter_LSC”;
itm.describe = “itmdescr_letter_LSC”;
itm.model = “letter”;
itm.picIndex = 16;
itm.picTexture = “ITEMS_4”;
itm.shown = 1;
itm.startLocation = “Marigo_HouseH2”;
itm.startLocator = “item1”;
itm.price = 0;
itm.Weight = 0.1;
itm.ItemType = “QUESTITEMS”;
n++;
This will ensure the letter always appears. However, it will have the wrong name and description (the same as the one in the Dutch GG’s chest). The names for the three different letters are itmname_letter_LSC, itmname_letter_LSC_1, and itmname_letter_LSC_2. The descriptions for the three different letters are itmdescr_letter_LSC, itmdescr_letter_LSC_1, and itmdescr_letter_LSC_2. Changing the lines to having one of those names and descriptions changes the those for all of the letters.
I thought I almost had a fix when I edited the items_utilite.c file, changing (_itemId == “letter_LSC”) to (_itemId == “letter_LSC_1”) and changing the itm.id, itm.name, and itm.describe lines in inititems.c to correspond with that, as well as adding the original lines back in above to ensure the letter in the GG’s chest had a separate name and descriptions. Hence it looked like this:
makeref(itm,Items[n]); //письмо для линейки ГПК
itm.id = “letter_LSC”;
itm.name = “itmname_letter_LSC”;
itm.describe = “itmdescr_letter_LSC”;
itm.model = “letter”;
itm.picIndex = 16;
itm.picTexture = “ITEMS_4”;
itm.price = 0;
itm.Weight = 0.1;
itm.ItemType = “QUESTITEMS”;
n++;
makeref(itm,Items[n]);
itm.id = “letter_LSC_1”;
itm.name = “itmname_letter_LSC_1”;
itm.describe = “itmdescr_letter_LSC_1”;
itm.model = “letter”;
itm.picIndex = 16;
itm.picTexture = “ITEMS_4”;
itm.shown = 1;
itm.startLocation = “Marigo_HouseH2”;
itm.startLocator = “item1”;
itm.price = 0;
itm.Weight = 0.1;
itm.ItemType = “QUESTITEMS”;
n++;
This completely fixed the issues with those two items and the quest still worked correctly. However, when I went to the City of Abandoned Ships and looked in the Fernando Diffindur chest, that letter was the same as the letter in the GG’s chest. I’m guessing if I found all of the locators and the like I could just add another set of lines like the above for letter_LSC_2, but the fact is using the unedited file, all of the letters have the right descriptions. I’ve been looking through a lot of files, a lot of which you can find letter_LSC in or other things relating to the quest. I’m guessing there is a file or files having to do with these quests that I’m just not finding. The real problem is I just don’t know where to look to fix this.
